-
Notifications
You must be signed in to change notification settings - Fork 132
Rename MCPServer CRD Port Attributes for Clarity #1806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Rename `port` to `proxyPort` - represents proxy runner port - Rename `targetPort` to `mcpPort` - represents MCP server port This change addresses user confusion about port semantics as discussed in issue #1452. The new names clearly indicate which port corresponds to which component: - proxyPort: Port exposed by the proxy runner in Kubernetes - mcpPort: Port that the MCP server listens on internally Updated all relevant files: - CRD types definition and generated YAML - Operator controller logic - All example and test YAML files - Keycloak deployment example 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Chris Burns <[email protected]>
lol, I approved before looking at the CI run 🤦🏻 |
I'll pull it locally and run the docs steps |
Signed-off-by: ChrisJBurns <[email protected]>
Signed-off-by: ChrisJBurns <[email protected]>
Signed-off-by: ChrisJBurns <[email protected]>
Signed-off-by: ChrisJBurns <[email protected]>
Signed-off-by: ChrisJBurns <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1806 +/- ##
==========================================
- Coverage 47.29% 47.29% -0.01%
==========================================
Files 223 223
Lines 27681 27681
==========================================
- Hits 13092 13091 -1
- Misses 13591 13593 +2
+ Partials 998 997 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: ChrisJBurns <[email protected]>
shouldn't we resurrect this PR? |
@jhrozek ahh yep, let me add this to the list of things to get soon ASAP. I think the only thing thats left is to just make sure we can leave the old fields in for a few versions and make them as deprecated. this is so we don't break existing setups |
@claude rebase and fix the merge conflicts |
Claude finished @ChrisJBurns's task —— View job Rebasing and Fixing Merge ConflictsI've investigated the current state of the branch and identified the issue, but I'm unable to complete the rebase due to tool permissions. Current Situation
What Needs to HappenThe branch needs to be rebased onto the latest
Required CommandsSince I don't have permission to run # Fetch latest changes
git fetch origin
# Rebase onto main
git rebase origin/main
# If conflicts occur, resolve them and continue
git rebase --continue
# Force push the rebased branch (since rebase rewrites history)
git push origin claude/issue-1452-20250827-1021 --force-with-lease Potential Conflict to Watch ForThe OIDC refactor (commit
Alternative: If you can grant me permission to run |
port
toproxyPort
- represents proxy runner porttargetPort
tomcpPort
- represents MCP server portThis change addresses user confusion about port semantics as discussed in issue #1452. The new names clearly indicate which port corresponds to which component:
Updated all relevant files:
🤖 Generated with Claude Code